Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattening of the wavelet coefficients #93

Open
zaccharieramzi opened this issue Apr 1, 2020 · 1 comment
Open

Flattening of the wavelet coefficients #93

zaccharieramzi opened this issue Apr 1, 2020 · 1 comment

Comments

@zaccharieramzi
Copy link
Contributor

Right now, the wavelet coefficients in WaveletN are flattened. I guess this is because the scalar product was "easier" to perform then.

However we could use vdot. And therefore we wouldn't need to flatten the coefficients and could use them in other ways like to solve #66 .

It would also prevent errors like calling the adjoint operator first (which as of now doesn't fail elegantly):

import numpy as np
from mri.operators import WaveletN
coeffs = np.zeros((16,))
linear_op = WaveletN(wavelet_name='haar', nb_scale=2)
adj_tr = linear_op.adj_op(coeffs)
@chaithyagr
Copy link
Contributor

I think this is related to #66 . As we change the flow of how we promote sparsity, we can also work on getting adjoint right. However, will still retain this issue for completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants