From a8c6bdd78c94d04cbe7419cc563f4b16d6278a87 Mon Sep 17 00:00:00 2001 From: Pavel Siska Date: Wed, 9 Oct 2024 14:11:46 +0200 Subject: [PATCH 1/2] telemetry - fix undocumented Holder constructors --- include/telemetry/holder.hpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/telemetry/holder.hpp b/include/telemetry/holder.hpp index 7e122e1..06cae8b 100644 --- a/include/telemetry/holder.hpp +++ b/include/telemetry/holder.hpp @@ -38,7 +38,17 @@ class Holder { Holder(const Holder& other) = delete; Holder& operator=(const Holder& other) = delete; - Holder(Holder&& other) = default; + /** + * @brief Move constructor + * @param other Other holder + */ + Holder(Holder&& other) = delete; + + /** + * @brief Move assignment + * @param other Other holder + * @return Reference to this holder + */ Holder& operator=(Holder&& other) = default; /** From a5880ca258a13c22c26e92b0fb03af99003bad42 Mon Sep 17 00:00:00 2001 From: Pavel Siska Date: Wed, 9 Oct 2024 14:00:53 +0200 Subject: [PATCH 2/2] github-action - doxygen now reports warning as errors --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index a6b6f56..1aa7c4e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -51,7 +51,7 @@ jobs: dnf config-manager --set-enabled ol9_codeready_builder dnf install -y doxygen - name: make doxygen - run: make doxygen + run: make doxygen CMAKE_ARGS="-DDOXYGEN_WARN_AS_ERROR=YES" - name: upload Doxygen artifact uses: actions/upload-artifact@v4 with: