You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of the merge of #44e24f37f disabled interrupts when yielding in the scheduler.
It's not clear whether the comment on yield_interrupt_enabled which describes the need for enabling interrupts still applies.
A simple test of a thread calling thread_sleep with interrupts disabled worked as expected: the thread was suspended, yielded and the idle thread was scheduled allowing timer interrupts to be received.
We should think about this and, at the very least, fix the comment.
The text was updated successfully, but these errors were encountered:
I still don't understand the comment and it is now even more confusing as the function does not enable interrupts. If you think it's fine as is we should rename the function to just yield and remove the comment.
As of the merge of #44 e24f37f disabled interrupts when yielding in the scheduler.
It's not clear whether the comment on
yield_interrupt_enabled
which describes the need for enabling interrupts still applies.A simple test of a thread calling
thread_sleep
with interrupts disabled worked as expected: the thread was suspended, yielded and the idle thread was scheduled allowing timer interrupts to be received.We should think about this and, at the very least, fix the comment.
The text was updated successfully, but these errors were encountered: