Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion/Warning when setting action.data #44

Open
lepmik opened this issue Oct 3, 2019 · 0 comments
Open

Assertion/Warning when setting action.data #44

lepmik opened this issue Oct 3, 2019 · 0 comments

Comments

@lepmik
Copy link
Member

lepmik commented Oct 3, 2019

When using action.data['name'] = 'name.something' it is nicely retrieved with action.data_path('name'), however, if an absolute path or relative path is set in action.data, data_path will not work properly. Either we can assert that the 'name.something' is not a path or we can warn and say that data_path will not work, or just disabling it. I vote for an assertion, i.e. forcing the user to put data in 'action_path/data'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant