Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration Testing framework using GitHub actions #315

Open
rbeucher opened this issue Jan 29, 2024 · 6 comments
Open

Continuous Integration Testing framework using GitHub actions #315

rbeucher opened this issue Jan 29, 2024 · 6 comments

Comments

@rbeucher
Copy link
Contributor

I have started a repo on the ACCESS-NRI organisation to automate testing of the recipes:
https://github.com/ACCESS-NRI/COSIMA-recipes-workflow

This is to eventually replace the Jenkins server on access-dev which will be shut down in Q1 2024.

This is based on what I have set up for the ESMValTool recipes:

https://github.com/ACCESS-NRI/ESMValTool-workflow?tab=readme-ov-file#recipes-current-status

Will keep you posted.

@anton-seaice
Copy link
Collaborator

Thanks Romain

All recipes in test/test_notebooks.py currently run with the exceptions of :

  • SeaIce_Obs_Model_Compare which works fine in ARE, but fails as a Gadi job because it relies on accessing data through a URL / online. This relies on the NSIDC Sea Ice Conc dataset - which I think is being added to project CT11 for esmvaltool.

These two recipes need some review / rework and are currently not expected to pass

Some recipes have cells which are expected to fail / show errors for the purposes of the recipes. These cells are marked with a 'skip-execution' cell tag which skips that cell when run as the Jenkins job, but runs the rest of the notebook below the skipped cell. (It would be even better if they weren't skipped, but it was checked that they generated the expected error and the rest of the notebook was run!)

@rbeucher
Copy link
Contributor Author

rbeucher commented Jan 29, 2024

SeaIce_Obs_Model_Compare which works fine in ARE, but fails as a Gadi job because it relies on accessing data through a URL / online. This relies on the NSIDC Sea Ice Conc dataset - which I think is being added to project CT11 for esmvaltool.

@flicj191 is working on a CMOR compatible version for ESMValTool.

@navidcy
Copy link
Collaborator

navidcy commented Jul 12, 2024

@rbeucher where are we with this? in the cosima-recipes we dropped Jenking so now we have no CI at all... is there a chance that we use the framework you are proposing now?

@navidcy
Copy link
Collaborator

navidcy commented Jul 12, 2024

Our repo file structure changed a lot btw. Do we want the testing to be in a different repo as you have started it @rbeucher or is this just a prototype to see whether the testing works. Seems good and it's great that you get a green or red badge! I'm very interested in incorporating in this repo so people know straight up whether the notebooks are working.

@navidcy navidcy changed the title COSIMA recipes testing framework using github actions Continuous Integration Testing framework using GitHub actions Jul 12, 2024
@rbeucher
Copy link
Contributor Author

Hi @navidcy ,

I think the testing should go in the COSIMA repo.
It needs a bit of refactoring and I need to adjust the folder structure. I'll have a look next week.

@navidcy
Copy link
Collaborator

navidcy commented Jul 19, 2024

Great! Exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants