Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #45

Open
ubaldot opened this issue May 31, 2022 · 0 comments
Open

Some suggestions #45

ubaldot opened this issue May 31, 2022 · 0 comments

Comments

@ubaldot
Copy link

ubaldot commented May 31, 2022

Today I used Sippy and I was very pleased.
It is very lean and it just do what is supposed to do without too many bells & whistles.
THIS is the way I love software! Very good job!

Nevertheless, I would suggest to give the user the possibility of selecting a validation dataset and to compute at least the basic metrics for validating the identified model, namely:

  1. Model fit in percentage
  2. Residuals auto-correlation analysis result
  3. Input-residual cross-correlation analysis result

A sketch of the code could be something like the following (at least for the first point I mentioned)

# Residuals
eps = Y_val-y_hat.transpose() # Y_val is the output data used for validation, y_hat is the identified model output and eps is the residual  
Y_val_bar = np.mean(Y_val, axis=0)
FIT_perc = np.round((1.0-np.linalg.norm(eps)/np.linalg.norm(Y_val-Y_val_bar))*100, 3)
print(FIT_perc)

Second suggestions is to set an option to get the system matrices in canonical observable form.
This is very handy when the outputs match with the actual sensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant