Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix B tag calibrations #52

Open
watson-ij opened this issue May 15, 2018 · 14 comments
Open

Fix B tag calibrations #52

watson-ij opened this issue May 15, 2018 · 14 comments
Assignees

Comments

@watson-ij
Copy link
Contributor

This is a high-effort task, probably we want to involve a one person from each of the groups.

Daniel, Yechan, can you point to the documentation so we can get people up to speed?

@SangMLee
Copy link
Collaborator

I am pretty sure that this is the b-tagging method that we are currently trying to use

some additional materials

@watson-ij
Copy link
Contributor Author

@watson-ij
Copy link
Contributor Author

@watson-ij
Copy link
Contributor Author

Theres also python code in nanoAOD-tools that seems to deal with this, its really ugly though:

https://github.com/cms-nanoAOD/nanoAOD-tools/blob/master/python/postprocessing/modules/btv/btagSFProducer.py

@SangMLee
Copy link
Collaborator

SangMLee commented Jun 14, 2018

BTag weights now come as an event weight with the nanoAOD root files in v5 of the productions
variable: btagWeight_CSVV2

@watson-ij
Copy link
Contributor Author

What about uncertainties?

@SangMLee
Copy link
Collaborator

they're not in the root file
Does that mean we are unable to use the ones in the root file ?

@watson-ij
Copy link
Contributor Author

I assume its calculated correctly, but to do systematics we will need to get the uncertainties so we probably still need to implement it anyway

@SangMLee SangMLee reopened this Jun 14, 2018
@jshlee
Copy link
Collaborator

jshlee commented Sep 13, 2018

is this finished? can we close?

@watson-ij
Copy link
Contributor Author

btag systematics?

@jshlee
Copy link
Collaborator

jshlee commented Nov 13, 2018

fyi - nanoAOD has btagging weights by default
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/nano_cff.py#L57-L90

@quark2 can you look into this

@quark2
Copy link
Contributor

quark2 commented Nov 15, 2018

I have no idea which one (the measurementType; iterativeFit or mujets, ttbar, etc; see https://twiki.cern.ch/twiki/bin/viewauth/CMS/BtagRecommendation80XReReco#AK4%20jets) to use. There is no prescription about this. I just found that CATTools guys are using 'iterativeFit', same as nanoAOD guys, but I don't know why they chose that. Jason suggested to compare them in my analysis.

@watson-ij
Copy link
Contributor Author

Are we happy with btagging+systs as currently implemented?

@quark2
Copy link
Contributor

quark2 commented Nov 29, 2018

I think okay.
FYI (or TMI), anyone who wants to use other measurementType can replace it in his/her analyser and that's all. So, everything is neat well, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants