-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy in probability/chi^2 #51
Comments
So what you think is most correct. Would be nice to see the impact of this on the example test cases as a minimum. |
Khaldoon graciously provided three test cases along with their outputs from MEM i.e.
|
This looks remarkably clean. I'm ok with changing the convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported by Manuel Zingl and Khaldoon Ghanem (thanks both!) there are some potential subtle problems with definitions. The code seems to use
Q=chi^2 / Ndat - alpha*S
in the minimization routine rather than the reportedQ=1/2chi^2 - alpha*S
Current options:
Ndat
version ofQ
and fixQ
andchi2
functions in the codeThe text was updated successfully, but these errors were encountered: