Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No HDF5 integration with Eigen3 matrices #9

Open
ryanlevy opened this issue Jul 24, 2015 · 3 comments
Open

No HDF5 integration with Eigen3 matrices #9

ryanlevy opened this issue Jul 24, 2015 · 3 comments
Assignees
@galexv
Labels
enhancement help wanted

Comments

@ryanlevy
Copy link
Collaborator

In ublas_vector.hpp there was the save method, which is incompatible with MatrixXd etc. HDF5 output in the Eigen3 branch has been commented out for now
@ryanlevy ryanlevy added the bug label Jul 24, 2015
ryanlevy added a commit that referenced this issue Jul 25, 2015
@ryanlevy
add back hdf5 out
88fb717 
This is a rough hack, temp fix for #9
ryanlevy added a commit that referenced this issue Jul 26, 2015
@ryanlevy
partial eigen hdf5 support
f879bd2 
better fix for #9
@ryanlevy
Copy link
Collaborator Author

Eigen::VectorXd (Matrix<double,1,Dynamic>) is now supported for saving. Not sure if it makes sense to implement all of the member functions in alps/hdf5/vector

@egull
Copy link
Contributor

egull commented Jul 27, 2015

Probably does make sense, and we can add this to Alex' todo list ;-) it should be easy to do and we're siwtching over to Eigen from Ublas anyway.

@egull egull closed this as completed Jul 27, 2015
@egull egull reopened this Jul 27, 2015
@egull
Copy link
Contributor

egull commented Jul 27, 2015

(reopened, closed by accident)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galexv galexv

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@galexv @egull @ryanlevy