Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement authentication API #41

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Implement authentication API #41

merged 7 commits into from
Sep 21, 2024

Conversation

glemenneo
Copy link

Changelog:

  • Add passport-local to handle authentication logic
  • Add login API
  • Add jsonwebtoken to generate access tokens using RS256 assymetric encryption
  • Add env validation and a new config class to retrieve environment variables. This will make it easier to mock environment variables in unit tests.

@glemenneo glemenneo added the enhancement New feature or request label Sep 20, 2024
@glemenneo glemenneo self-assigned this Sep 20, 2024
@glemenneo glemenneo linked an issue Sep 20, 2024 that may be closed by this pull request
[BE] [User Service] Implement authentication API #12
Closed
@glemenneo glemenneo force-pushed the 12-be-user-service-implement-authentication-api branch from 961eb02 to 3c76562 Compare September 21, 2024 05:28
lynnlow175
lynnlow175 approved these changes Sep 21, 2024
View reviewed changes
Copy link

@lynnlow175 lynnlow175 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glhf

@lynnlow175 lynnlow175 merged commit 6d18564 into main Sep 21, 2024
1 check passed
@glemenneo glemenneo deleted the 12-be-user-service-implement-authentication-api branch September 23, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynnlow175 lynnlow175 lynnlow175 approved these changes

@shishirbychapur shishirbychapur Awaiting requested review from shishirbychapur shishirbychapur is a code owner

@yunruu yunruu Awaiting requested review from yunruu yunruu is a code owner

@Daviancold Daviancold Awaiting requested review from Daviancold Daviancold is a code owner

Assignees

@glemenneo glemenneo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone D2: SPA + REST API Development
Development

Successfully merging this pull request may close these issues.

[BE] [User Service] Implement authentication API
2 participants
@glemenneo @lynnlow175