Feat login #43
Merged
Feat login #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a failed SSR hydration in this branch |
lynnlow175
requested review from
shishirbychapur,
glemenneo,
Daviancold and
yunruu
as code owners
|
There is some margin here in the root div, i think it should be removed to match the figma, otherwise looks good to me! |
|
Additionally the toast box is at the bottom, perhaps @yunruu @shishirbychapur ya'll can take a look at this too |
whats wrong? |
|
the toast can be fixed later imo, currently the page isn't functional yet, and the error message is generic. for now, i think it's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.