Fix CICD Errors (#129)

* Fix Backend CI checks * Update backend cicd workflow * Install ESlint in github action * Install ESLint for Github Action * Configure BE CICD * Remove global eslint * Remove unneccessary checks * Update deployment config
CS3219-AY2425S1 · Nov 12, 2024 · 2dad575 · 2dad575
1 parent 518c351
commit 2dad575
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 21 deletions.
diff --git a/.github/workflows/backend-ci-workflow.yaml b/.github/workflows/backend-ci-workflow.yaml
@@ -40,16 +40,3 @@ jobs:
             npm run build
             cd ../..
           done
-
-      # Lint Check for Each Service
-      - name: Lint Each Service
-        run: |
-          npm install -g eslint
-
-          services=("auth-service" "code-execution-service" "collaboration-service" "gateway-service" "matching-service" "question-service" "user-service" "y-websocket-service")
-          for service in "${services[@]}"; do
-            echo "Linting $service"
-            cd backend/$service
-            npm run lint
-            cd ../..
-          done
diff --git a/k8s/start-k8s.sh → k8s/apply-k8s.sh b/k8s/start-k8s.sh → k8s/apply-k8s.sh
diff --git a/k8s/auth-service/auth-deployment.yaml b/k8s/auth-service/auth-deployment.yaml
@@ -18,7 +18,7 @@ spec:
       containers:
         - name: auth-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/auth-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3003
           envFrom:

diff --git a/k8s/code-execution-service/code-execution-deployment.yaml b/k8s/code-execution-service/code-execution-deployment.yaml
@@ -18,7 +18,7 @@ spec:
       containers:
         - name: code-execution-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/code-execution-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3006
           envFrom:

diff --git a/k8s/collaboration-service/collaboration-deployment.yaml b/k8s/collaboration-service/collaboration-deployment.yaml
@@ -18,7 +18,7 @@ spec:
       containers:
         - name: collaboration-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/collaboration-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3005
           envFrom:

diff --git a/k8s/gateway-service/gateway-deployment.yaml b/k8s/gateway-service/gateway-deployment.yaml
@@ -16,7 +16,7 @@ spec:
       containers:
         - name: gateway-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/gateway-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 4000
           env:

diff --git a/k8s/matching-service/matching-deployment.yaml b/k8s/matching-service/matching-deployment.yaml
@@ -16,7 +16,7 @@ spec:
       containers:
         - name: matching-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/matching-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3004
           envFrom:

diff --git a/k8s/question-service/question-deployment.yaml b/k8s/question-service/question-deployment.yaml
@@ -18,7 +18,7 @@ spec:
       containers:
         - name: question-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/question-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3002
           envFrom:

diff --git a/k8s/user-service/user-deployment.yaml b/k8s/user-service/user-deployment.yaml
@@ -18,7 +18,7 @@ spec:
       containers:
         - name: user-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/user-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3001
           envFrom:

diff --git a/k8s/y-websocket-service/y-websocket-deployment.yaml b/k8s/y-websocket-service/y-websocket-deployment.yaml
@@ -18,7 +18,7 @@ spec:
       containers:
         - name: y-websocket-service
           image: asia-southeast1-docker.pkg.dev/peerprep-438213/peerprep/y-websocket-service:latest
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 4001
           envFrom: