Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collaboration Bug Fixes #131

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Collaboration Bug Fixes #131

merged 2 commits into from
Nov 12, 2024

Conversation

jmsandiegoo
Copy link

Fixes the following bugs:

  • Collaboration websocket not returning any acks
  • Yjs env variable typo
  • SessionContext.tsx designed to handle ack callbacks that doesn't work in cloud environment.

@jmsandiegoo jmsandiegoo added bug Something isn't working backend frontend labels Nov 12, 2024
@jmsandiegoo jmsandiegoo added this to the Milestone 7 milestone Nov 12, 2024
@jmsandiegoo jmsandiegoo self-assigned this Nov 12, 2024
@jmsandiegoo jmsandiegoo changed the title Jmsandiegoo/bugfix Collaboration Bug Fixes Nov 12, 2024
rickkoh
rickkoh approved these changes Nov 12, 2024
View reviewed changes
Copy link

@rickkoh rickkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@rickkoh rickkoh merged commit 71fae00 into main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickkoh rickkoh rickkoh approved these changes

@Jajared Jajared Awaiting requested review from Jajared

@evanyan13 evanyan13 Awaiting requested review from evanyan13

Assignees

@jmsandiegoo jmsandiegoo

Labels
backend bug Something isn't working frontend
Projects
None yet
Milestone
Milestone 7
Development

Successfully merging this pull request may close these issues.
2 participants
@jmsandiegoo @rickkoh