Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor xkcd code to be more modular #146

Open
3 tasks
royh02 opened this issue Jul 28, 2021 · 0 comments
Open
3 tasks

Refactor xkcd code to be more modular #146

royh02 opened this issue Jul 28, 2021 · 0 comments
Labels
medium 3 officer points wishlist

Comments

@royh02
Copy link
Member

royh02 commented Jul 28, 2021

The current xkcd code is not very modular, making other refactoring efforts hard. I suggest the following:

  • Move all async logic (including sending messages) to the main bot.py file and only have xkcd.py handle retrieving xkcd comic. This way, xkcd.py functions more like a util file, which it is.

  • Change the method of handling messages to handling args so that it's consistent with other commands. After finishing the task above, this part becomes easier.

  • Add a small description about what the command does using description and brief. Refer to other commands as examples. This should be quick and fun! 😄

@royh02 royh02 changed the title Refactor xkcd code Refactor xkcd code to be more modular Jul 28, 2021
@royh02 royh02 added medium 3 officer points wishlist labels Jul 28, 2021
@royh02 royh02 added this to To do in Root Staff via automation Jul 28, 2021
@royh02 royh02 removed this from To do in Root Staff Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium 3 officer points wishlist
Projects
None yet
Development

No branches or pull requests

1 participant