556 compatibility inquiry avaloniaui #851
Conversation
…indowmanager Expose ShowDialogAsync in IWindowManager.
Handle application lifetime events.
…a_11 Update to Avalonia 11.0.0-preview5.
5.0.31-beta # Conflicts: # src/Caliburn.Micro.Platform/Caliburn.Micro.Platform.csproj
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/NavigationFrame.cs
Fixed
Show fixed
Hide fixed
src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/WindowConductor.cs
Fixed
Show fixed
Hide fixed
Updated dotnet.yml to refine NuGet push pattern. Replaced MessageBinder.SpecialValues.Add with TryAdd in tests. Removed redundant cast in ActionMessage.cs. Switched to ConcurrentDictionary in MessageBinder.cs and improved formatting. Enhanced ViewLocator.cs with custom name formatting and validation methods.
| return providedValue; | ||
| } | ||
|
|
||
| if (CustomConverters.ContainsKey(destinationType)) { | ||
| if (CustomConverters.ContainsKey(destinationType)) |
Check notice
Code scanning / CodeQL
Inefficient use of ContainsKey Note
rolled back some changes in viewmodellocator add NameFormat validation to viewLocator
Added logging statements to various methods in `Screen.cs`, `ActionMessage.cs`, `NavigationFrame.cs`, and `View.cs` to log lifecycle events, execution context, content changes, layout updates, and errors. Moved `elementToUse` assignment in `ActionMessage.cs` for correct usage. Changed `NavigationFrame` to inherit from `ContentControl` instead of `TransitioningContentControl`. Updated `ExecuteOnLoad` method in `View.cs` to use `Loaded` event for Avalonia. Modified equality checks in `OnModelChanged` and `OnContextChanged` methods in `View.cs` to use `==` instead of `.Equals`. Refactored `SetContentPropertyCore` method in `View.cs` for readability and added exception logging. Added new method `GetContentPropertyName` in `View.cs` for retrieving content property name with improved formatting.
| { | ||
| Log.Info("Transition completed"); | ||
| var control = e.To as UserControl; | ||
| if (control != null && e.To != e.From) |
Check warning
Code scanning / CodeQL
Reference equality test on System.Object Warning
| #if AVALONIA | ||
| public static bool ExecuteOnLoad(FrameworkElement element, EventHandler handler) | ||
| { | ||
| if (((Control)element).IsLoaded) |
Check warning
Code scanning / CodeQL
Cast to same type Warning
| if (args.OldValue == args.NewValue) { | ||
| static void OnModelChanged(DependencyObject targetLocation, DependencyPropertyChangedEventArgs args) | ||
| { | ||
| if (args.OldValue == (args.NewValue)) |
Check warning
Code scanning / CodeQL
Reference equality test on System.Object Warning
| if (e.OldValue == e.NewValue) { | ||
| static void OnContextChanged(DependencyObject targetLocation, DependencyPropertyChangedEventArgs e) | ||
| { | ||
| if (e.OldValue == (e.NewValue)) |
Check warning
Code scanning / CodeQL
Reference equality test on System.Object Warning
Add Avalonia ui support