-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output #11
Comments
Progress made with PR #26 |
It would be good to add all of the output writers to an output writer holder struct that is then a field in the simulation. |
Right now we stop writing when there are no floes. This might not be the optimal behavior, especially once we have packing as more floes could re-enter the simulation |
I want to re-write calc_eulerian_data! to be more efficient as it requires so much unnecessary polygon clipping right now. However, this will have to wait until after the switch to GO clipping. |
We are swapping over to saving the polygon rather than coordinates for floes. This then means that we won't have to store the coordinates anymore, or really anything that can be determined from the floe's polygon (area, centroid, area, rmax, angles). I think maybe we should re-do the floe writers to depend on the Floe's sub-structs... If I break it down so that the floe has very simple writing mechanism, this will make it easier for users to write new writers that give them the information that they need. I will need to think more on how to do this. |
Improve output speed and functionality
The text was updated successfully, but these errors were encountered: