Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting #36

Closed
2 tasks
skygering opened this issue Feb 21, 2023 · 4 comments
Closed
2 tasks

Plotting #36

skygering opened this issue Feb 21, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@skygering
Copy link
Contributor

  • Allow plotting functions to take in any Julia specifications to personalize the plots
  • Add ocean vectors
@skygering skygering added the enhancement New feature or request label Feb 21, 2023
@skygering
Copy link
Contributor Author

Plots is causing all type of problems with animations. For example (JuliaPlots/Plots.jl#4213). Plotting should be moved to Makie or another library.

@skygering
Copy link
Contributor Author

skygering commented Jun 20, 2024

We did switch to Makie. However, I now think that this should be abstracted from the code entirely. Since we are now swapping over to having the Polygons be stored by the Floe objects, I think we can just have a Floe output writer that saves the polygon objects in a file that is meant to store shapes (along with a floe ID).

These are super easy to write with GeoInterfaceMakie. In that case, there is barely any plotting code that is needed... this might be an example of a good extension... or maybe even just an example script. I am not sure on what the best format is.

@skygering
Copy link
Contributor Author

I have now moved the plotting code to an extension that is only loaded when CairoMakie is loaded. We should still switch to using GeoInterfaceMakie to plot the polygons directly and clean up some of the included code. However, making it into an extension should help reduce the pre-compliation time.

@skygering
Copy link
Contributor Author

The above comments are addressed in #99! It is now merged to main and this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant