Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularity of the Floe Struct #95

Open
skygering opened this issue Jun 20, 2024 · 1 comment
Open

Modularity of the Floe Struct #95

skygering opened this issue Jun 20, 2024 · 1 comment

Comments

@skygering
Copy link
Contributor

I think it would be nice if the Floe fields were organized into different sub-structs whose type influences the type of the Floe.

For example, all of the information needed for time stepping could be in a TimeSteppingInformation struct that is a concrete type AbstractTimeSteppingInformation. Then it would be really easy to try different time stepping methods without having to completely re-write the code base.

This might also just make it easier to read and understand given the Floe struct is massive.

@skygering
Copy link
Contributor Author

skygering commented Jun 20, 2024

We will need a better idea of how this effects StructArrays: JuliaArrays/StructArrays.jl#85. This is a good start to understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant