-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularity of the Floe Struct #95
Comments
We will need a better idea of how this effects StructArrays: JuliaArrays/StructArrays.jl#85. This is a good start to understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be nice if the Floe fields were organized into different sub-structs whose type influences the type of the Floe.
For example, all of the information needed for time stepping could be in a
TimeSteppingInformation
struct that is a concrete typeAbstractTimeSteppingInformation
. Then it would be really easy to try different time stepping methods without having to completely re-write the code base.This might also just make it easier to read and understand given the Floe struct is massive.
The text was updated successfully, but these errors were encountered: