Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AppBar Close/Open by id #2344

Closed
1 task done
jolevesq opened this issue Jul 4, 2024 · 0 comments · Fixed by #2377
Closed
1 task done

[BUG] AppBar Close/Open by id #2344

jolevesq opened this issue Jul 4, 2024 · 0 comments · Fixed by #2377
Assignees

Comments

@jolevesq
Copy link
Member

jolevesq commented Jul 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

AppBar button id are like details, layers.... if we have more then one map on the page, because id is the same..

Line 57 app-bar-helper.ts
// put back focus on calling button
document.getElementById(buttonId)?.focus();

** If there is more the 1 map, only the latest added app bar plugins is displated on the appBar**

Expected Behavior

We should use the geoviewContainer pass as param to the function from the component and use query selector

Plugins should be added even if more then 1 map

Steps To Reproduce

  1. https://canadian-geospatial-platform.github.io/geoview/public/esri-feature.html
  2. Open guide on map 1
  3. Open guide on map 2
  4. Close guide on map2, focus is now on map 1

Use the loading package and add a new map with with id, same config

  <div id="mapWM" class="geoview-map" data-lang="en" data-config-url="./configs/loading-packages-config.json"></div>
  <div id="mapWM1" class="geoview-map" data-lang="en" data-config-url="./configs/loading-packages-config.json"></div>

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants