Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes break search #2

Open
jvanulde opened this issue Jul 4, 2024 · 1 comment
Open

Quotes break search #2

jvanulde opened this issue Jul 4, 2024 · 1 comment
Assignees

Comments

@jvanulde
Copy link
Member

jvanulde commented Jul 4, 2024

Tried searching with the following string:

silt "fraser river" delta

Error returned:

Error: SyntaxError: Bad escaped character in JSON at position 111 (line 1 column 112)

@xinli-cai
Copy link
Member

After @anthonyfok's investigation, the error is possibly due to AWS API Gateway does not accept " in the query.

Anthony also noticed https://app.geo.ca/ frontend filters out any " and ' altogether, and we might just expose the problem through the demo. For example, try the query Indigenous people's culture, and you'll see keyword search failing with a different error.

Solutions:

  1. Fix the '' and ' escape from https://app.geo.ca/ frontent
  2. Perfom query sanitization not just on the frontend but also on the backend if feasible
    FYI @bo-lu @PVautour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants