From 385354b03dccd94e3a125ddf428d3d4b15f8cff1 Mon Sep 17 00:00:00 2001 From: George Herbert Date: Sun, 25 Feb 2024 19:24:43 +0000 Subject: [PATCH] chore: remove pages router version --- ui/src/app/projects/[projectId]/traces/page.tsx | 2 -- ui/src/models/responses/trace-detail-response.ts | 8 +++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/ui/src/app/projects/[projectId]/traces/page.tsx b/ui/src/app/projects/[projectId]/traces/page.tsx index 441e157..8da1a6b 100644 --- a/ui/src/app/projects/[projectId]/traces/page.tsx +++ b/ui/src/app/projects/[projectId]/traces/page.tsx @@ -16,8 +16,6 @@ export default async function Traces({ params, searchParams }: startDate?: string, endDate?: string, feedbackFilters?: string - - //TODO - inLast is not used in the original code inLast?: string } }) { diff --git a/ui/src/models/responses/trace-detail-response.ts b/ui/src/models/responses/trace-detail-response.ts index bbf4c66..11a4a8c 100644 --- a/ui/src/models/responses/trace-detail-response.ts +++ b/ui/src/models/responses/trace-detail-response.ts @@ -20,10 +20,8 @@ export interface TraceTreeNode { totalTokens?: number; depth?: number; feedback?: { [key: string]: any }; //TODO Make this a proper type - - execution_order?: number; //TODO This is only used for old format (pre version....) - - trace_id?: string; //TODO This is only used for new format (post version....) - dotted_order?: string; //TODO This is only used for new format (post version....) + execution_order?: number; // (<= langsmith-sdk v0.0.90) + trace_id?: string; // (>= langsmith-sdk v0.0.90) + dotted_order?: string; // (>= langsmith-sdk v0.0.90) }