Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test passes but texts are not exported to release ? #114

Open
PonteIneptique opened this issue Oct 11, 2017 · 6 comments
Open

Test passes but texts are not exported to release ? #114

PonteIneptique opened this issue Oct 11, 2017 · 6 comments
Assignees

Comments

@PonteIneptique
Copy link
Member

On https://github.com/PerseusDL/canonical-latinLit phi1017.phi015 passes all tests :

https://travis-ci.org/PerseusDL/canonical-latinLit/builds/278749515#L3461

but is not contained in the release :

https://travis-ci.org/PerseusDL/canonical-latinLit/builds/278749515#L6396-L6400

I have few that could share the same issue :

+    +    urn:cts:latinLit:phi0472.phi001.perseus-lat2 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi1017.phi015.perseus-lat2 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi0119.phi001.perseus-lat2 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi0474.phi035.perseus-lat1 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi0917.phi001.perseus-lat2 was not found in the corpus but is annotated
@PonteIneptique
Copy link
Member Author

Could you have a look @sonofmun ?

@sonofmun
Copy link
Contributor

I will take a look at it when I get a chance.

@sonofmun
Copy link
Contributor

sonofmun commented Jul 2, 2018

@PonteIneptique What is the status of this issue? Were these perhaps texts that had empty references and thus were not parsable even though they passed Hook? Or is the problem somewhere else?

@PonteIneptique
Copy link
Member Author

I have never chased down this issue unfortunately. It should definitely be checked :)

@sonofmun
Copy link
Contributor

sonofmun commented Jul 2, 2018

The question is whether they error now that Hook checks for empty refs. This was the type of problem that led me to recognize the problem with Hook.

@PonteIneptique
Copy link
Member Author

We should have a check on this. I probably won't have time for it this week though .

@PonteIneptique PonteIneptique self-assigned this Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants