Changed actuator state to be an atomic bool #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bskdany
commented
Nov 17, 2024
bskdany
commented
- Changed actuator state to be atomic bool
- Added back actuator_set function
- Changed padstate_actuate and padstate_get_actstate to not lock the mutex anymore
|
I love members who actively listen at PDRs! Will review tomorrow but thank you for the jump start! |
|
Fixed all actuator state atomics, I forgot how they worked in C so I was just setting values instead of using the helper functions from stdatomic |
EliasJRH
reviewed
Nov 26, 2024
EliasJRH
previously approved these changes
Nov 26, 2024
EliasJRH
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.