OSFstorage provider "inner provider" settings?

[krugar]

The OSFstorage provider has an "inner provider" that can be filesystem for local testing or a cloud storage for production. This provider is initialized in a utility function named make_provider(), which can be called with a settings parameter:

waterbutler/waterbutler/providers/osfstorage/provider.py

Line 129 in ef09929

def make_provider(self, settings):

one place where this is called from is within download(), where it is indeed called with a settings parameter (with data taken from a "metadata" response by the OSF)

however, within make_provider(), this settings parameter is not actually used to initialize the inner provider, the value used instead is this:

waterbutler/waterbutler/providers/osfstorage/provider.py

Line 142 in ef09929

self.settings['storage'],

This seems... unintended?

I stumbled upon this while trying to provide a foldersetting to the filesystem provider via environment variables, which does not work as one might expect (because it is initialized via the above mechanism)