Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime filtering #119

Open
praftery opened this issue Oct 22, 2021 · 2 comments
Open

Datetime filtering #119

praftery opened this issue Oct 22, 2021 · 2 comments
Assignees

Comments

@praftery
Copy link

  • As it currently stands, if someone is interested in a specific period of time each day (e.g. 9am-5pm), they have to define and apply that filter on every plot they want it on. It would be easier/better to do this once, when needed. Consider adding an option to apply/change the filter across all relevant tabs.
  • Additionally, in plots where more visualization dimensions can clearly be added without overloading the plot, it may be better to combine filtered periods with the unfiltered annual data, rather than just dropping the unfiltered data For example, for the natural ventilation plots, the bar chart could easily show both 'all hours' and 'time filter applied' hours (e.g. lines in red below). image
  • In plots that inherently show one of the filter values as a dimension (e.g. heat maps), maybe it's better to keep the data and just add horizontal/vertical lines (on apply a partially transparent mask to grey it out)? It would save on processing/data/load times etc and seems a bit more intuitive that completely whiting out the plot.
  • Maybe allow filtering by datetime features for the descriptive statistics table in the data explorer?
  • As with the other plots, the psychrometric chart needs to have an annotation stating when it has been time filtered (to prevent user error on download)
@praftery
Copy link
Author

One additional point regarding the caption text that explains that a plot has been filtered. It would be better if this was a plot annotation, or something similar so that when a user downloads the svg image, that filtering information is still on there.

@giobetti
Copy link
Contributor

giobetti commented Oct 24, 2021

Several points here, so I am opening separate issues for those.

One is to make sure to review all graph titles and make sure that the title is part of the downloadable graphic to avoid confusion #122

As it currently stands, if someone is interested in a specific period of time each day (e.g. 9am-5pm), they have to define and apply that filter on every plot they want it on. It would be easier/better to do this once, when needed. Consider adding an option to apply/change the filter across all relevant tabs.
I believe this would be quite cumbersome to implement. Also different graphs might need different time filters (i.e. UTCI and natural ventilation) Also, this is sort of implemented already in the "Data Explorer" tab in the "Customizable heatmap" where you can set the time and variable filter and those will be kept even if you change the variable to be displayed.

Additionally, in plots where more visualization dimensions can clearly be added without overloading the plot, it may be better to combine filtered periods with the unfiltered annual data, rather than just dropping the unfiltered data
The disadvantage here would be that it woul be difficult to answer the question "what percentage of the selected time x happens?" while now it is trivial.

In plots that inherently show one of the filter values as a dimension (e.g. heat maps), maybe it's better to keep the data and just add horizontal/vertical lines (on apply a partially transparent mask to grey it out)? It would save on processing/data/load times etc and seems a bit more intuitive that completely whiting out the plot.
We experimented with this and where not really satisfied with the grahical output (often very confusing to read) It might be a matter of tast but I find it way clearer as it is.

Maybe allow filtering by datetime features for the descriptive statistics table in the data explorer?
Could be a good enhancement opened as #123

As with the other plots, the psychrometric chart needs to have an annotation stating when it has been time filtered (to prevent user error on download)
part of #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants