Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdoor comfort tab issue with bootstrap #190

Open
FedericoTartarini opened this issue May 1, 2023 · 2 comments
Open

Outdoor comfort tab issue with bootstrap #190

FedericoTartarini opened this issue May 1, 2023 · 2 comments
Assignees

Comments

@FedericoTartarini
Copy link
Contributor

Hi, please copy the code from the natural ventilation tab which resizes the components as a function of the windows with. In the latest implementation of the filter the responsive design has not been implemented and when I resize the window the filter and the dropdown overlap. It should be an easy fix since you just need to use dash bootstrap components and copy the code from the natural ventilation tab.

image

The window should look something like this one:
image

@danielh7-cs9
Copy link
Contributor

Hi @FedericoTartarini,
I've fixed this. See below screenshots.

image

When resizing:
image

image

Before I submit my pull request I just wanted your thoughts on whether we should put the "Select scenario filter" in the first column Div (As I have done it my first screenshot above). Reason I ask is because I think it will create more consistency with other tabs, for example, Psychrometric tab filter and the the customization heatmap filter in the data explorer tab. e.g.

image

image

@FedericoTartarini
Copy link
Contributor Author

FedericoTartarini commented May 7, 2023

Hi @danielh7-cs9 thank you so much for working on this but it would be ideal if the dropdown would have a size of 12, i.e. occupy all the space available when on small screen since at the moment it is not rendering well. What I mean is that the dropdown should be at the top and then in a new row there should be the filter. Also on small screens please remove the padding or the white margin since it is not needed and takes away space. The above change should be very simple to implement with dash bootstrap components, just pass something like md-12 or sm-12 to fix the issue.

Yes, you can put the Select scenario first.

image

FedericoTartarini added a commit that referenced this issue May 19, 2023
#190 Outdoor comfort tab issue with bootstrap (updated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants