-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis to GitHub Actions #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like equivalent changes to travis, with some improvements. I'm excited to use it.
Just some assorted questions due to my own ignorance. Looks good to go though.
One more observation. All the jobs are slower than their equivalent travis jobs. All but the macOS build are ~2x slower. Even with this, the times still seem reasonable. |
I'm guessing this is because we're building/testing the release configuration, too, now. If the extra build time is a problem, we could separate the debug and release configurations into separate jobs. Or even remove the release build entirely, to go back to the way things were on Travis. |
This is ready for another look. |
Makes sense. More work, more time needed. I like the idea of catching release build problems, release test problems. Sounds worth it to me. |
Ha yeah apparently GitHub just removed Clang 12 support from their Linux runner: Should be able to switch to |
So that we can use Clang 12.
d155e35
to
0f19eea
Compare
No description provided.