Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium3DTileset's "Enable Water Mask" option has a decoy checkbox #1538

Open
kring opened this issue Oct 31, 2024 · 1 comment
Open

Cesium3DTileset's "Enable Water Mask" option has a decoy checkbox #1538

kring opened this issue Oct 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kring
Copy link
Member

kring commented Oct 31, 2024

image

I couldn't figure out why disabling the water mask wasn't working. Until I realized I was unchecking the first box, which is... well, I have no idea what it is. But I know now that it doesn't actually disable the feature. To disable that water mask, you have to keep that one checked, and uncheck the rightmost one.

We should figure out where this dodgy decoy checkbox is coming from and get rid of it.

@kring kring added the bug Something isn't working label Oct 31, 2024
@azrogers
Copy link
Contributor

azrogers commented Nov 1, 2024

I believe this is a result of the EditCondition meta flag on the EnableWaterMask UPROPERTY, as detailed here. I think the first box edits the boolean that EditCondition points to (which is bIsMac in this case), whereas the second box actually changes the value. What a bizarre feature.

We can probably get rid of this by either adding EditConditionHides to hide the property if on Mac, or by creating a CanEditChange method to disable it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants