From daa2b08a7720085b435eeca4cabd10a2438ba83a Mon Sep 17 00:00:00 2001 From: Josh <8007967+jjspace@users.noreply.github.com> Date: Fri, 2 Feb 2024 10:19:47 -0500 Subject: [PATCH 1/3] remove externals for build --- vite.config.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/vite.config.js b/vite.config.js index 2cb8f14..8c2b873 100644 --- a/vite.config.js +++ b/vite.config.js @@ -26,9 +26,4 @@ export default defineConfig({ ], }), ], - build: { - rollupOptions: { - external: ["http", "https", "url", "zlib"], - }, - }, }); From 6722f57ab1df1766e07d5f80a6fc5767e6edc27c Mon Sep 17 00:00:00 2001 From: Josh <8007967+jjspace@users.noreply.github.com> Date: Fri, 2 Feb 2024 10:21:20 -0500 Subject: [PATCH 2/3] fix husky pre-commit --- .husky/pre-commit | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 .husky/pre-commit diff --git a/.husky/pre-commit b/.husky/pre-commit old mode 100644 new mode 100755 From a33727e512c5a9514405a28a74ef841268eb2779 Mon Sep 17 00:00:00 2001 From: Josh <8007967+jjspace@users.noreply.github.com> Date: Fri, 2 Feb 2024 11:11:18 -0500 Subject: [PATCH 3/3] update package.json and readme --- README.md | 14 ++++++++++++++ package.json | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 491eb07..4bf6c27 100644 --- a/README.md +++ b/README.md @@ -89,6 +89,20 @@ import "cesium/Build/Cesium/Widgets/widgets.css"; import "@cesium/engine/Source/Widget/CesiumWidget.css"; ``` +## CesiumJS before version `1.114` + +If you are using a version of CesiumJS before `1.114` you will need to modify the config to tell it to ignore some external node dependencies. Add the `build` section below: + +```js + build: { + rollupOptions: { + external: ["http", "https", "url", "zlib"], + }, + }, +``` + +See cesium PR [#11773](https://github.com/CesiumGS/cesium/pull/11773) for more information + ## Contributions Pull requests are appreciated. Please use the same [Contributor License Agreement (CLA)](https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md) used for [Cesium](https://cesium.com/). diff --git a/package.json b/package.json index 147d7ed..6085657 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "vite-plugin-static-copy": "^1.0.0" }, "dependencies": { - "cesium": "^1.113.0" + "cesium": "^1.114.0" }, "lint-staged": { "*.{js,html}": [