-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lotus' OpenRPC definitions are inaccurate #3668
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Forest wants to use Lotus' OpenRPC definitions to ensure RPC compatibility.
But we've found that most endpoints are incorrect.
Here are some examples:
Snippets are taken from Lotus' OpenRPC definitions, and extraneous items have been redacted for brevity.
Tested against Lotus v1.23.3
Objects in spec do not match objects in practice
Claims to return an
array
of emptyobject
s:[ {}, {}, {} ]
, but actually returns anarray
ofstring
sClaims to accept a
string
but in actually accepts only objects like{ "/": "<some CID>" }
.Note that the example does match the schema.
The schema does not represent all (stable) endpoints
Filecoin.Version
does not appear in the schema, but is callable, and appears in the documentationThe text was updated successfully, but these errors were encountered: