-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We don't follow the JSON-RPC spec when closing a channel #4453
Comments
cc @elmattic |
We definitely have an issue when sending the closing response (after getting the channel cancel payload from the client). Lotus closing message: Forest closing message: I don't think it really matters to set ID to something in this context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
forest/src/rpc/channel.rs
Line 318 in 42964f8
The response should contain the id of the request, but ours in unconditionally
null
The text was updated successfully, but these errors were encountered: