Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't follow the JSON-RPC spec when closing a channel #4453

Open
aatifsyed opened this issue Jun 26, 2024 · 2 comments
Open

We don't follow the JSON-RPC spec when closing a channel #4453

aatifsyed opened this issue Jun 26, 2024 · 2 comments
Assignees

Comments

@aatifsyed
Copy link
Contributor

let resp = close_channel_response(channel_id);

The response should contain the id of the request, but ours in unconditionally null

@aatifsyed
Copy link
Contributor Author

cc @elmattic

@elmattic
Copy link
Contributor

elmattic commented Jul 1, 2024

We definitely have an issue when sending the closing response (after getting the channel cancel payload from the client).

Lotus closing message:
{"jsonrpc":"2.0","method":"xrpc.ch.close","params":[<channel_id>]}

Forest closing message:
{"jsonrpc":"2.0","result":{"jsonrpc":"2.0","method":"xrpc.ch.close","params":[<channel_id>]},"id":null}

I don't think it really matters to set ID to something in this context.

@elmattic elmattic self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants