Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Ethereum mapping TTL corner case #4466

Open
5 tasks
elmattic opened this issue Jul 1, 2024 · 0 comments
Open
5 tasks

Handle Ethereum mapping TTL corner case #4466

elmattic opened this issue Jul 1, 2024 · 0 comments

Comments

@elmattic
Copy link
Contributor

elmattic commented Jul 1, 2024

Issue summary

The Ethereum mapping TTL feature allows entries to be deleted after a setup duration (e.g., twenty-four hours).

After this period, RPC methods involving mapping like:

  • Filecoin.EthGetMessageCidByTransactionHash
  • Filecoin.EthGetTransactionByHash

and in some circumstances, could return a non-null result even though the Hash to Cid entry has been correctly deleted.

Task summary

  • Find some of those hashes using calibnet_eth_mapping_check CI script
  • Investigate how Lotus behaves for those hashes
  • We should either properly document this behavior because it can be a source of surprise for API consumers
  • OR we should find a way to handle those corner cases and always return null when an entry has been deleted
    (This could be done by transforming back the Cid to an Hash and seeing if there's a match)

Acceptance Criteria

  • Add unit test covering this corner case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant