Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIP-0091 support for Ethereum RPC methods. #4477

Closed
LesnyRumcajs opened this issue Jul 3, 2024 · 2 comments · Fixed by #4523
Closed

FIP-0091 support for Ethereum RPC methods. #4477

LesnyRumcajs opened this issue Jul 3, 2024 · 2 comments · Fixed by #4523
Assignees
@hanabi1224 @elmattic

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Jul 3, 2024 •
edited
Loading

Issue summary

While consensus-critical logic was implemented in the linked PR, corresponding RPC methods still require changes.

Other information and links

Follow-up for #4473
@LesnyRumcajs LesnyRumcajs changed the title FIP-00951 support for Ethereum RPC methods. FIP-0091 support for Ethereum RPC methods. Jul 4, 2024
@LesnyRumcajs
Copy link
Member Author

@elmattic Would you be interested in taking this?

@LesnyRumcajs LesnyRumcajs mentioned this issue Jul 4, 2024
Closed
@elmattic elmattic self-assigned this Jul 4, 2024
@hanabi1224 hanabi1224 mentioned this issue Jul 12, 2024
Merged
4 tasks
@hanabi1224 hanabi1224 linked a pull request Jul 12, 2024 that will close this issue
fix(rpc): update eth_tx_from_signed_eth_message to support legacy transactions #4523
Merged
4 tasks
@hanabi1224
Copy link
Contributor

It turns out the fix to #4518 and #4519 fixes this one as a side effect.

@hanabi1224 hanabi1224 self-assigned this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanabi1224 hanabi1224

@elmattic elmattic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rpc): update eth_tx_from_signed_eth_message to support legacy transactions ChainSafe/forest
3 participants
@hanabi1224 @LesnyRumcajs @elmattic