-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render swagger-ui on root endpoint in rest api #1060
Comments
Do you want to bundle up with the beacon chain code the swagger UI, or add it to our CI pipeline publicly like https://api.prylabs.network/ ? |
I think it would be useful to bundle it. cc @wemeetagain |
My preference is to not bundle it, or somehow only optionally bundle it for debugging. |
Other clients don't bundle it up. Should this still be pursued? If we follow https://github.com/ethereum/eth2.0-APIs strictly is it necessary to maintain our own swagger UI? |
As I compromise, we could add redirect from lodestar api base url to https://github.com/ethereum/eth2.0-APIs . It would be REALLY nice if we could pass server url somehow. That said, we are missing /eth prefix on all routes |
Would like this feature behind a CLI flag. |
Resolved with #5970 |
It would be nice instead of 404 to render swagger-ui on http://localhost: to load swagger-ui with our server as primary server url.
Until we release spec, we should probably bundle spec into single file and ship it along.
There is some fastify plugin for that probably
The text was updated successfully, but these errors were encountered: