Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using Lodestar as a failover #5323

Closed
wemeetagain opened this issue Mar 30, 2023 · 11 comments
Closed

Error using Lodestar as a failover #5323

wemeetagain opened this issue Mar 30, 2023 · 11 comments
Labels
prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.

Comments

@wemeetagain
Copy link
Member

From discord (https://discord.com/channels/593655374469660673/743858262864167062/1090175408340733962):

I have a setup where a teku validator uses Lodestar as a failover.
image

however when it tries to connect, Lodestar returns this error

@philknows philknows added prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. labels Mar 31, 2023
@Chozowarrior
Copy link

also tested on Goerli with same results

@Chozowarrior
Copy link

The other way around. Teku as failover for Lodestar VC does work but does display some errors in the logging:
image

@dapplion
Copy link
Contributor

dapplion commented Jun 1, 2023

The other way around. Teku as failover for Lodestar VC does work but does display some errors in the logging: image

What version of Teku are you using? execution_optimistic should be implemented by all clients now

@Chozowarrior
Copy link

The other way around. Teku as failover for Lodestar VC does work but does display some errors in the logging: image

What version of Teku are you using? execution_optimistic should be implemented by all clients now

yes the otherway around issue has been resolved but the main issue (Lodestar as failover for Teku has not been resolved yet).

@dapplion
Copy link
Contributor

dapplion commented Jun 2, 2023

@Chozowarrior Could you share the version of the Teku beacon node that the Lodestar validator client of your screen capture? Then I can check with Teku devs to see if they are complying with the beacon API spec

@Chozowarrior
Copy link

@Chozowarrior Could you share the version of the Teku beacon node that the Lodestar validator client of your screen capture? Then I can check with Teku devs to see if they are complying with the beacon API spec

You mean validator client right? I was using Teku 23.3.1 as a validator at the time. I was also in contact with the Teku team regarding this issue. since there was also a different issue on their side because after failing to connect to Lodestar it would not successfully attest after connecting to a different failover. That was this issue in case it is of any interest Consensys/teku#7016 I was in contact with Stefan Bratanov regarding this.

@nflaig
Copy link
Member

nflaig commented Jul 21, 2023

@Chozowarrior Are you still running Lodestar as a failover node with Teku VC? The errors you reported should be fixed now by #5722 and #5784 but those should not have caused actual issues (just noise).

I am running Lodestar and Teku in a 1:1 setup which works great with the latest releases. Would be interesting to know if this issue is resolved by now. If you deploy from unstable branch the noisy eventstream errors should be gone too.

@Chozowarrior
Copy link

@nflaig yes I am still using Lodestar as a failover for some validators and as a primary for others as well. It is working for last month or so indeed so that is great. The behavior together with Teku only shows some errors that are maybe a bit overdone. The Teku dev told me the default behaviour is that the Teku-VC sends the attestations to the primary node plus all failover nodes to maximize the propogation. However this results in error messages on the Lodestar when the attestation has already been gossiped (see below). The behaviour in Nimbus which is a 2nd failover is different as this just blindly attests without the check that Lodestar seems to have.

However this issue is can indeed be closed but wonder whether the below is still interesting to look into as this error look messy, maybe info would be better here.

jul 21 23:01:25 ssay-NUC8i5BEH lodestar[1557]: Jul-21 23:01:25.336[api] error: Error on submitPoolAttestations [0] slot=6929105, index=40 code=ATTESTATION_ERROR_ATTESTATION_ALREADY_KNOWN, targetEpoch=216534, validatorIndex=XXXX

@nflaig
Copy link
Member

nflaig commented Jul 21, 2023

Thanks for the detailed answer. Great to hear that it works for you as well. Indeed, the error might be a bit annoying but as far as I know this does not cause any issues.

@tuyennhv wdyt? could we log this error with that specific code to debug instead?

@twoeths
Copy link
Contributor

twoeths commented Jul 23, 2023

@nflaig I think we should implement ignoreIfKnown flag, it's to be true for api validation but false for gossip validation

even when we use Lodestar as the primary node, submitted attestations can reach our node by gossip before the api since vc can published to fallback node already

@nflaig
Copy link
Member

nflaig commented Oct 5, 2023

Closing as errors mentioned in this issue have been resolved #5323 (comment).

The other error mentioned in #5323 (comment) is tracked in a different issue.

@nflaig nflaig closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.
Projects
None yet
Development

No branches or pull requests

6 participants