-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve recomputeForkChoiceHead #5852
Comments
this is part of the effort to handle more validators coming to ethereum, see #5855 |
0810_updateHead_perf_test.cpuprofile.zip this issue is caused by |
@tuyennhv please research the following:
With this we pay a higher ocassional cost, but then we never have to check if descedant of finalized. My concern is that finalized checkpoint can change at times where the node is hot. But it should be worth it to benchmark how expensive this remapping operation is |
Describe the bug
In mainnet node it could take up to 0.5s to
recomputeForkChoiceHead
and it takes 6% of cpu in total
while out benchmark says <= 100ms
see #5836 (comment)
Expected behavior
Get back to the level of v1.9.x
Steps to reproduce
No response
Additional context
No response
Operating system
Linux
Lodestar version or commit hash
v1.10.0
The text was updated successfully, but these errors were encountered: