Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken IGNORE/REJECT metrics #5853

Closed
twoeths opened this issue Aug 6, 2023 · 3 comments
Closed

Broken IGNORE/REJECT metrics #5853

twoeths opened this issue Aug 6, 2023 · 3 comments
Assignees
@twoeths
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@twoeths
Copy link
Contributor

twoeths commented Aug 6, 2023

Describe the bug

Starting from v1.10.0 we're not able to see IGNORE/REJECT by topics, instead it's just IGNORE/REJECT in general. This is likely an issue of gossipsub after we upgraded in v1.10.0

  • This is from unstable 1k node
Screenshot 2023-08-06 at 15 47 38
  • This is from stable test mainnet node
Screenshot 2023-08-06 at 15 48 12 Screenshot 2023-08-06 at 15 48 25

Expected behavior

Should be able to view IGNORE/REJECT messages by topic

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.10.0
@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Aug 6, 2023
@twoeths
Copy link
Contributor Author

twoeths commented Aug 7, 2023

This is a breaking change from https://github.com/ChainSafe/js-libp2p-gossipsub/pull/433/files

with this change, it's not possible to know which topic has % of ignore/reject/accept

@twoeths twoeths self-assigned this Aug 7, 2023
@twoeths twoeths mentioned this issue Aug 7, 2023
Merged
@twoeths
Copy link
Contributor Author

twoeths commented Aug 14, 2023

waiting for #5869 to update these metrics on grafana

@twoeths
Copy link
Contributor Author

twoeths commented Aug 24, 2023

closed via #5899

@twoeths twoeths closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoeths twoeths

Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twoeths