Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate --builder.urls usage #6181

Closed
wemeetagain opened this issue Dec 12, 2023 · 1 comment · Fixed by #6190
Closed

Investigate --builder.urls usage #6181

wemeetagain opened this issue Dec 12, 2023 · 1 comment · Fixed by #6190

Comments

@wemeetagain
Copy link
Member

Builder is a bit of an outlier right now, we allow to set multiple URLs via --builder.urls but only use the first URL (opts.urls[0]). I opted to only log the URL which is actually used.

@g11tech Is it intentional that we don't allow a fallback for the builder? I guess mev-boost is already doing the multiplexing and builder flow is stateful which makes fallback logic a bit problematic.

Maybe we want to reflect that in the CLI as well as currently it looks like it supports multiple urls

image

Originally posted by @nflaig in #6175 (comment)

@g11tech
Copy link
Contributor

g11tech commented Dec 13, 2023

Right because of the multiplexing by mev boost , may be we can still multiplex on top but we haven't felt the need so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants