Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support builder boost factor in proposer settings file #6304

Closed
nflaig opened this issue Jan 16, 2024 · 1 comment · Fixed by #6357
Closed

Support builder boost factor in proposer settings file #6304

nflaig opened this issue Jan 16, 2024 · 1 comment · Fixed by #6357
Labels
good first issue Issues that are suitable for first-time contributors. meta-feature-request Issues to track feature requests.

Comments

@nflaig
Copy link
Member

nflaig commented Jan 16, 2024

Problem description

We are not supporting boostFactor in proposer settings file but instead only on the keymanager API

type ProposerConfigFileSection = {
graffiti?: string;
strict_fee_recipient_check?: string;
fee_recipient?: string;
builder?: {
// boolean are parse as string by the default schema readFile employs
// for js-yaml
gas_limit?: number;
selection?: routes.validator.BuilderSelection;
};
};

Solution description

Add builder.boostFactor to proposer settings file to allow per validator configuration

Additional context

No response

@nflaig nflaig added meta-feature-request Issues to track feature requests. good first issue Issues that are suitable for first-time contributors. labels Jan 16, 2024
@nflaig
Copy link
Member Author

nflaig commented Jan 16, 2024

Needs to apply same validation as CLI arg --builder.boostFactor added in #6332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. meta-feature-request Issues to track feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant