Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Disable workflow summary creation #132

Closed
ArnaudLacroix opened this issue Jul 31, 2023 · 3 comments
Closed

[REQ] Disable workflow summary creation #132

ArnaudLacroix opened this issue Jul 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ArnaudLacroix
Copy link

Is your request related to a workflow problem?

Incremental scan output summary can be misleading to user by showing 0 vulnerabilities when other vulnerabilities already exist. Could we have an option to not generate the summary.

Propose a solution

Add a new parameter to the action, to disable the creation of a workflow summary.

@ArnaudLacroix ArnaudLacroix added the enhancement New feature or request label Jul 31, 2023
@ArnaudLacroix ArnaudLacroix changed the title [REQ] [REQ] Disable workflow summary creation Jul 31, 2023
@Yoavast
Copy link

Yoavast commented Aug 16, 2023

Thank you for bringing this to our attention. To ensure I understand correctly, are you referencing instances where the Incremental scan shows "0 vulnerabilities" even when vulnerabilities exist from previous scans? Is this in comparison to the results from the last full scan?

Furthermore, could you provide more insight into your perspective on the value of a scan that doesn't display any results?

Thank you for your input!

@ArnaudLacroix
Copy link
Author

The issue occurs when a scan is launched asynchronously:
By the time the CLI tries to retrieve scan's results, it gets nothing (as the scan is not complete yet), and generate an output with 0 vulnerabilities.
I already proposed a simple code change to prevent this behaviour (see PR #134)

@pedrompflopes
Copy link
Collaborator

Hi @ArnaudLacroix

We fixed this in the latest version.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants