Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness control on Raven is broken #236

Closed
4 tasks done
MizuKumi opened this issue Mar 14, 2024 · 8 comments
Closed
4 tasks done

Brightness control on Raven is broken #236

MizuKumi opened this issue Mar 14, 2024 · 8 comments
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@MizuKumi
Copy link

MizuKumi commented Mar 14, 2024

macOS Version

Ventura

What is your CPU's model?

AMD Ryzen 5 PRO 3500U

Please describe the behaviour in detail.

After upgrading to the latest version of NootedRed: https://github.com/ChefKissInc/NootedRed/actions/runs/8277805359 (commit [274ba77])

The brightness control stopped working properly, the brightness reduction via the native "Brightness Slider" from macOS only goes down one point from the maximum brightness value, the brightness does not go any lower after moving the slider.

In the previous version of Nootedred:
https://github.com/ChefKissInc/NootedRed/actions/runs/7765787829 (Commit [eff598f])

The brightness control was working properly. Via the native "Brightness Slider" from macOS.

Videos demonstrating the problem are attached in two files.

Before:
https://github.com/ChefKissInc/NootedRed/assets/116596455/5e0ec249-8dbe-4360-8178-868efe9eb4d6

After:
https://github.com/ChefKissInc/NootedRed/assets/116596455/285fd8c8-38a0-4218-a8a4-97404bcb6f7d

What should've happened instead?

Brightness control, well, what else is there? :D

If applicable, attach the .gpuRestart, .panic, etc file related to this issue.

Pointless, the problem is inside Nootedred, apparently this problem appeared after commit d6554a3: https://github.com/ChefKissInc/NootedRed/actions/runs/8253163850

Bug report submission terms

  • I am using the latest version of NootedRed.
  • I am on the latest minor and patch version of macOS (ex. 7 is the minor and 10 is the patch of macOS 11.7.10).
  • The bug only happens with NootedRed enabled.
  • I have ruled out any external factors that could interfere, including, but not limited to, using OCLP or WhateverGreen.
@MizuKumi MizuKumi added the Bug Something isn't working label Mar 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NootedRed Mar 14, 2024
@VisualEhrmanntraut
Copy link
Member

What is the display type?

@MizuKumi
Copy link
Author

Where can I see this in macOS?

@VisualEhrmanntraut
Copy link
Member

I meant LCD, OLED, ... if it has HDR, etc.

@MizuKumi
Copy link
Author

MizuKumi commented Mar 14, 2024

does not have HDR
Screenshot 2024-03-14 at 17 01 32

@VisualEhrmanntraut
Copy link
Member

It seems like this issue is specific to Raven (DCN 1). I have not seen the issue occur on Renoir (DCN 2). It is possible that AMDRadeonX6000Framebuffer has a bug with the DMCU control. I will investigate how to solve this without removing the newly added Catalina support for brightness control and etc.

@MizuKumi
Copy link
Author

MizuKumi commented Mar 16, 2024

Okay. I look forward to your fix. And yes, thanks for such a great project, you made it possible for me not to buy a macbook for overprice. :)

@VisualEhrmanntraut VisualEhrmanntraut changed the title Brightness control on Vega 8 (Raven Ridge) broken after updating to latest version Nootedred Brightness control on Raven is broken Mar 25, 2024
@VisualEhrmanntraut VisualEhrmanntraut pinned this issue Mar 25, 2024
@VisualEhrmanntraut VisualEhrmanntraut moved this from 🆕 New to 📋 Backlog in NootedRed Mar 25, 2024
@ovoME
Copy link

ovoME commented Jun 28, 2024

An idea:maybe we can design a command for users to add boot-args to disable Catalina brightness control code, or delete Catalina brightness control code, because Catalina is outdated.

@ChefKissInc ChefKissInc locked and limited conversation to collaborators Jun 28, 2024
@VisualEhrmanntraut VisualEhrmanntraut added this to the Version 1.0.0 milestone Jul 23, 2024
@VisualEhrmanntraut
Copy link
Member

I improved the situation a little bit.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in NootedRed Oct 8, 2024
@VisualEhrmanntraut VisualEhrmanntraut unpinned this issue Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants