Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness control work in HDR, but not in SDR (Cezanne) #290

Closed
RasyiidWho opened this issue Aug 13, 2024 · 4 comments
Closed

Brightness control work in HDR, but not in SDR (Cezanne) #290

RasyiidWho opened this issue Aug 13, 2024 · 4 comments

Comments

@RasyiidWho
Copy link

RasyiidWho commented Aug 13, 2024

macOS Version

Ventura

What is your CPU's model?

Ryzen 7 5800H

Please describe the behaviour in detail.

The brightness control, both using Fn + brightness key and brightness slider only work when using HDR mode in Settings > Display. But when I turn it off (HDR -> SDR), the brightness aren't changing despite value of the slider are changing (slider work, but brightness still remain at 100%). This behaviour also occour on shutdown/reboot, before laptop shutdown/restart, screen goes to full brightness about 3 second.

Tried fresh install, changing to SDR and then reboot, changing HDR to SDR didn't solve the problem. This bug happen in both macOS that I've tested: Ventura & Sonoma.

Laptop: Legion 5 Pro 16ACH6H
Display spec: Built-in Display, 2560x1600 IPS 165Hz with HDR10.
NootedRed version: commit f7baa7a, but happend even in previous release commit 11f9df4.

What should've happened instead?

Brightness control should work both in SDR and HDR mode.

If applicable, attach the .gpuRestart, .panic, etc file related to this issue.

Will attach later..

Copy link

Greetings. It seems like this is the first issue you open on this repository.

We are letting you know that these are for bug reports or feature requests. Most of the reports we receive in this GitHub Organisation are user errors.

For the sake of saving time, here are the most common cases:

  • Outdated version of this kext.
  • Conflicts with other kexts (e.g. WhateverGreen).
  • Issues caused by other kexts like memory corruption (e.g. AirportItlwm).
  • Intended behaviour by Apple (e.g. V-Sync or cursor rendering).
  • Using cheap hacks like kext/library downgrades (e.g. OCLP, BFixup).
  • Duplicate kexts.
  • Malformed config.plist caused by configurator software (OCAT, OCC, etc).
  • Lack of TSC synchronisation or use of badly programmed TSC kext (only use ForgedInvariant).
  • Outdated macOS minor version (e.g. macOS 11.0.0 instead of latest).
  • Using beta versions of macOS.
  • Using the kext during installation or update. There is a Lilu bug which makes macOS stall during the last install phase.
  • Incorrect SMBIOS. Please use iMac20,1, MacBookPro16,3, MacPro7,1 or iMacPro1,1.
  • (e)DP link training failure. -NRedDPDelay will fix this as mentioned in the README. This is last resort, black screen can be caused by other factors mentioned.
  • Insufficient VRAM size.

We will never support the use of configurator software, solutions like OCLP/BFixup, or using macOS beta versions.

This issue will be looked over by the respective maintainer when they can. In the meantime, look if you can resolve this yourself via checking the above.

Be patient, we are hobbyists.

@RasyiidWho
Copy link
Author

Tried to checkout old commit (eff598f), as in #236 just to check if the problem are presist, and it is. Even in commit eff598f, SDR brightness control are broken.

@RasyiidWho RasyiidWho changed the title Brightness control work in HDR, but not in SDR (Renoir) Brightness control work in HDR, but not in SDR (Cezanne) Aug 13, 2024
@VisualEhrmanntraut
Copy link
Member

This seems more like a hardware limitation than a bug.

@VisualEhrmanntraut
Copy link
Member

Tracking in #293

@VisualEhrmanntraut VisualEhrmanntraut removed their assignment Sep 20, 2024
@VisualEhrmanntraut VisualEhrmanntraut closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants