-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Got 500 and SSLError on some urls #13
Comments
The whole monitoring system is a bit of a mess right now. I assigned this Issue to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If try to check some urls got a Internal service error (500)
Following deeper in code I found that cause in
requests.exceptions.SSLError
To Reproduce
Steps to reproduce the behavior:
Paste 'https://www.old.reddit.com' to textbox
Click on 'Check'
If enabled Debug in run.py, can catch exception via console:
requests.head(url, timeout=2, stream=True, allow_redirects=True)
See error
File "/Users/trx/.virtualenvs/servermon/lib/python3.7/site-packages/requests/adapters.py", line 514, in send raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='www.old.reddit.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError("hostname 'www.old.reddit.com' doesn't match either of '*.reddit.com', 'reddit.com', '*.redditmedia.com', 'redditmedia.com', '*.redd.it', 'redd.it', 'www.redditstatic.com', 'i.reddituploads.com', '*.thumbs.redditmedia.com', 'www.redditinc.com', 'redditinc.com'")))
`
Expected behavior
Should show real status, maybe better add a warning about SSL, or ignore it
Desktop (please complete the following information):
Additional context
Need wrap exception or do workaround. I'm don't sure what is better. Should programm check SSL or not?
Possible ignore it:
https://stackoverflow.com/questions/10667960/python-requests-throwing-sslerror
Example:
requests.get('https://kennethreitz.com', verify=False)
PS: I can take to work this issue after your decide what need to do with this error
The text was updated successfully, but these errors were encountered: