Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gsoc'24): report as spam and moderation review page #25

Merged
merged 19 commits into from
Aug 18, 2024

Conversation

Waishnav
Copy link

@Waishnav Waishnav commented Jun 25, 2024

Fixes #17

This PR's covers following functionality

  • improvised UI for actions like delete, edit, report spam, mark as solution using dropdown.
  • authenticated user can report any forum post as spam for review
  • moderators can delete reported spam post from moderators only route. threads/spam_reports

Note: For client side interaction like dropdown toggle, report spam modal form, javascript was needed so I've used hotwire stimulus controllers for this. and currently build files of these javascript assets are not pushed but to use this rails engine in production, we have to push these javascripts assets with the rails engine.

Screenshots:

image
image
image
image

@tachyons
Copy link
Member

Could you resolve the conflicts ? Also not all of these messages are spam. Make spam as a category and rename the text as "Report post".

Also don't push mark as solution to the dropdown, it's visibility will decrease.

@Waishnav
Copy link
Author

Also don't push mark as solution to the dropdown, it's visibility will decrease.

Yeah agreed with your point, but if we add this button in the forum post's footer, it will make post more crowdy with this action button.

Since all action regarding the forum post is now grouped using this dropdown, it just matter of time user will adopt to this feature as they gets used to this forum card layout. wdyt?

…r` gem

- these filters are applied on forum_thread's title, forum_posts's body
- error messages are now improves with proper altert message styling
  using bootstrap's alter class
@Waishnav
Copy link
Author

Waishnav commented Aug 6, 2024

image

@tachyons made that mark as solution and unmark as solution button visible outside of dropdown. Now it will be shown in the forum post's header like this.

@Waishnav
Copy link
Author

@tachyons I've added new tests for new functionality which I added. can you please re-review this PR

@tachyons tachyons merged commit 470e204 into CircuitVerse:master Aug 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderation Tools and Spam detection and Language Filters
2 participants