This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Define the Code analysis ProjectRuleSet file #501
Comments
I would like to discuss the rule SA 1309: FieldNamesMustNotBeginWithUnderscore Or we use the underscore to prefix the private fields or we use the prefix "this" |
Another question is regarding the usage of #Region Personally I like the regions because I can group implementations of a interface, all the public methods and all the private methods together (for example) and this can be very helpful to understand the code. |
aboimpinto
added a commit
to aboimpinto/neo-sharp
that referenced
this issue
Oct 22, 2018
shargon
pushed a commit
that referenced
this issue
Oct 23, 2018
* add CodeAnalysis to the solution * add symbolic link to the NeoSharp.Core project * merge with development. * Project Rule Set file defined and added to the projects. #501 * Ignoring failing tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Now that CodeAnalysis is successful installed in NeoSharp, it's time to define what rules the team want to see enforce by this process.
CoZ doesn't have a RuleSet defined then this could be a great opportunity to envolve @AshRolls to help choose this rules for this project and for all C# projects that CoZ support.
@gubanotorious as NeoSharp project mananger should be involved too and all the member of the team.
This task is a follow up of the #499 and after this should be created a task where the team should clean all the warning.
When the application is clean and without warnings we should change CodeAnalys behavior to create compile errors.
The text was updated successfully, but these errors were encountered: