Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FDScheme when calling SurfaceFluxes #2230

Closed
LenkaNovak opened this issue Oct 11, 2023 · 1 comment
Closed

Use FDScheme when calling SurfaceFluxes #2230

LenkaNovak opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@LenkaNovak
Copy link
Contributor

As found by @gdecker1 and @akshaysridhar , we are not calling FDScheme (correct for our vertical discretization) when calculating surface fluxes in ClimaAtmos, which assumes the default scheme (FVScheme).

@kmdeck, this may be relevant to you guys as well (though in practice it shouldn't change your values much).

@szy21
Copy link
Member

szy21 commented Oct 23, 2023

This has been updated in #2261

@szy21 szy21 closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants