Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary thermo state call #795

Closed
charleskawczynski opened this issue Sep 2, 2022 · 2 comments
Closed

Remove unnecessary thermo state call #795

charleskawczynski opened this issue Sep 2, 2022 · 2 comments
Assignees

Comments

@charleskawczynski
Copy link
Member

One of our calls to saturation adjustment is unnecessary-- we call thermo_state! in explicit horizontal advection, after it's been computed in the implicit tendency function, so it can be removed. If we want to be able to swap the order of these calls (which some timesteppers may require), then we should either prescribe a flag to call them in a particular order, or a flag to indicate whether it's already been computed or not.

@charleskawczynski
Copy link
Member Author

A flag for this is significantly easier without bycolumn calls

@charleskawczynski
Copy link
Member Author

I think that this will be closed when #2015 is closed, so I'll close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant