Skip rrtmgp callback in ode init #1932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the RRTMGP callback to skip on integrator initialization. I was looking into reducing latency, and found that this accounts for 97% of
integrator = ODE.init(...)(for cases with rrtmgp radiation). If this is behavior changing, then we should first think about whether this change makes sense (we can always call this callback after getting the integrator in the driver, or make a wrapper that does it), but I like the change at the very least because it decouples getting the integrator from doing computations. For example, if someone is debugging a job that has rrtmgp, but they want to call some other tendency, it doesn't make sense to do all of these extra computations.