Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Julia 1.9 #1998

Merged
merged 4 commits into from
Aug 30, 2023
Merged

upgrade to Julia 1.9 #1998

merged 4 commits into from
Aug 30, 2023

Conversation

simonbyrne
Copy link
Member

@simonbyrne simonbyrne commented Aug 17, 2023

Purpose

Upgrade our examples Manifest and pipeline to Julia 1.9.

To-do

  • tag a new release of ClimaCore

Content


  • I have read and checked the items on the review checklist.

@simonbyrne simonbyrne force-pushed the sb/julia-1.9 branch 3 times, most recently from 9400e33 to 1d6ce08 Compare August 17, 2023 23:01
@simonbyrne
Copy link
Member Author

This seems to speed up initialization in some cases

  • gravity wave: 4min => 2min
  • density current 17 min => 12 min

@simonbyrne
Copy link
Member Author

simonbyrne commented Aug 21, 2023

@simonbyrne simonbyrne force-pushed the sb/julia-1.9 branch 2 times, most recently from 8e940bc to 2d3b30a Compare August 21, 2023 22:38
@simonbyrne
Copy link
Member Author

@simonbyrne simonbyrne marked this pull request as ready for review August 24, 2023 18:03
@simonbyrne simonbyrne requested a review from szy21 August 24, 2023 18:03
@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 24, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2023

Build failed:

@szy21
Copy link
Member

szy21 commented Aug 24, 2023

bors r+

bors bot added a commit that referenced this pull request Aug 24, 2023
1998: upgrade to Julia 1.9 r=szy21 a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 24, 2023

Canceled.

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 24, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2023

Build failed:

@szy21
Copy link
Member

szy21 commented Aug 24, 2023

@simonbyrne
Copy link
Member Author

bors r+

@nefrathenrici nefrathenrici linked an issue Aug 24, 2023 that may be closed by this pull request
bors bot added a commit that referenced this pull request Aug 25, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



2016: remove nvtx macro r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 25, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Aug 25, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@Sbozzolo
Copy link
Member

@Sbozzolo This is the PR

Yes, I am looking into it.

@Sbozzolo
Copy link
Member

Sbozzolo commented Aug 28, 2023

I tracked it down to the new flag we added slurm_mem_per_cpu: 8G.

This minimal build starts.

I also verified that manually submitting a script with that option works (after you fiddle around with MPI/HDF5).

#!/bin/bash

#SBATCH --ntasks=2
#SBATCH --mem-per-cpu=8G
#SBATCH --job-name=MyTest
#SBATCH --time=0:23:00

module purge
module load julia/1.9.2 cuda/11.8 ucx/1.14.1_cuda-11.8 openmpi/4.1.5_cuda-11.8 hdf5/1.12.2-ompi415 nsight-systems/2023.2.1

export CLIMACORE_DISTRIBUTED="MPI"
export CLIMACOMMS_CONTEXT="MPI"

cd ClimaAtmos.jl

julia -e 'using Pkg; Pkg.add("MPIPreferences"); using MPIPreferences; use_system_binary()'
julia --project=examples -e 'using Pkg; Pkg.build("MPI")'
julia --project=examples -e 'using Pkg; Pkg.build("HDF5")'
julia --project=examples -e 'using Pkg; Pkg.API.precompile()'
srun julia --color=yes --project=examples examples/hybrid/driver.jl --config_file config/mpi_configs/mpi_make_restart.yml

So, I am guessing that buildkite-slurm bridge is not properly translating the option.

EDIT: I also tested that the job starts ~immediately when I submit it with walltime of 6 hours.

@szy21
Copy link
Member

szy21 commented Aug 28, 2023

Great, thanks! If all other ci jobs work, I am happy to get this in and remove the slurm_mem_per_cpu flag. We can also wait until Simon comes back - up to you.

@simonbyrne
Copy link
Member Author

Ah, I think it's because we set --mem (globally for all jobs), and that must be incompatible with --mem-per-cpu

@Sbozzolo
Copy link
Member

Sbozzolo commented Aug 29, 2023 via email

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 29, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



2035: Remove unused struct member surface_scheme r=charleskawczynski a=charleskawczynski

This PR removes `surface_scheme`, which is unused. Thanks to `@Sbozzolo` 

Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@simonbyrne
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Canceled.

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2023
1998: upgrade to Julia 1.9 r=simonbyrne a=simonbyrne



2035: Remove unused struct member surface_scheme r=charleskawczynski a=charleskawczynski

This PR removes `surface_scheme`, which is unused. Thanks to `@Sbozzolo` 

Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6e7b1f8 into main Aug 30, 2023
8 checks passed
@bors bors bot deleted the sb/julia-1.9 branch August 30, 2023 04:46
@simonbyrne
Copy link
Member Author

Fixes #2001

@simonbyrne simonbyrne linked an issue Aug 30, 2023 that may be closed by this pull request
@simonbyrne simonbyrne mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Julia 1.9 Fix Longrun Pipeline
3 participants