Remove parameters from config #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/remove_config_params
branch
from
b7ef2c5 to
d400692
Compare
4 tasks
nefrathenrici
force-pushed
the
ne/remove_config_params
branch
6 times, most recently
from
11ddb90 to
15be21e
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 31, 2023
2021: Remove parameters from config r=nefrathenrici a=nefrathenrici ## Content - Removes the following config options: C_E, alpha_rayleigh_w, alpha_rayleigh_uh, zd_viscous, zd_rayleigh, kappa_2_sponge - Instead of being set via config, these values are added to ClimaAtmosParameters via a SpongeParameters struct, except for C_E, which is at the top-level - Add TOMLs for CI cases that need to change the values above. One file per case. - Updates .dev manifest to 1.9.2 - Update juliaformatter to 1.9 Co-authored-by: nefrathenrici <nat.henrici@gmail.com>
|
bors r- |
|
Canceled. |
nefrathenrici
force-pushed
the
ne/remove_config_params
branch
from
15be21e to
bfb2a02
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 31, 2023
2021: Remove parameters from config r=nefrathenrici a=nefrathenrici ## Content - Removes the following config options: `C_E`, `alpha_rayleigh_w`, `alpha_rayleigh_uh`, `zd_viscous`, `zd_rayleigh`, `kappa_2_sponge` - Instead of being set via config, these values are added to ClimaAtmosParameters via a SpongeParameters struct, except for `C_E`, which is at the top-level - Add TOMLs for CI cases that need to change the values above. One file per case. - Updates .dev manifest to 1.9.2 - Update juliaformatter to 1.9 Co-authored-by: nefrathenrici <nat.henrici@gmail.com>
|
Build failed: |
|
bors r- |
nefrathenrici
force-pushed
the
ne/remove_config_params
branch
from
bfb2a02 to
fefcc43
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
C_E,alpha_rayleigh_w,alpha_rayleigh_uh,zd_viscous,zd_rayleigh,kappa_2_spongeC_E, which is at the top-level